Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade stack to ES Modules and TypeScript #47

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

noherczeg
Copy link

@noherczeg noherczeg commented Jan 17, 2025

Time has passed since the inception of this library and so did standards and best practices when it comes to JavaScript libraries.

Given that we already had a request at #43 I took the initiative to update the stack with the following concepts:

  • Added support for NVM to make NodeJS version maintenance easier
  • Added Biome formatter to keep the code format consistent
  • TypeScript makes source code less error-prone due to it's type-system, and checks
  • The ECMAScript standard has evolved, now ES Modules are standard, there is no need for require
  • Build pipeline was outdated, moved to Vite
  • Tests have been migrated to Vitest to keep the stack concise

This PR is not yet finished, most of the docs need to be updated, but every test runs, and examples are working.

Looking forward for your response.

@noherczeg noherczeg changed the title Upgrade stack Upgrade stack to ES Modules and TypeScript Jan 17, 2025
@noherczeg
Copy link
Author

As a side-note: I didn't want to re-write the whole code-base from scratch, therefore larger files are kept as-is, and inheritance hasn't been applied everywhere (yet?) although I think we could.

@ghillairet
Copy link
Member

@noherczeg Thanks for this work, but not sure what to do about it. I definitely will not support this project anymore as you see how old are those last commits.
I can merge it but not sure I can or remember how to publish it.
Would it make sense for you to just fork it if you really want to use it?

@noherczeg
Copy link
Author

@ghillairet

Thank you so much for your amazing work on this project, it’s been incredibly valuable to us. We wanted to let you know that we plan to move our modified version of the library under our organization, BlackBeltTechnology, with a new name, ecore-ts, and publish it on NPM.

We’ll make sure to credit your original work both in the documentation and metadata so your efforts are properly recognized. If you have any concerns or feedback, please let us know!

Thanks again for creating such a great foundation.

Best regards,
Norbert

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants