Improve service discovery, implement SD for CalDav #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpeukert
commented
Sep 6, 2020
|
Test failure seems unrelated. |
emersion
reviewed
Oct 13, 2020
| serviceUrl := u.String() | ||
|
|
||
| // Check if the resulting URL hosts a service | ||
| req, err := http.NewRequest(http.MethodOptions, serviceUrl, nil) |
There was a problem hiding this comment.
RFC 6764 section 6 mandates that a PROPFIND request should be made with the username/password set.
Alps has a different requirement: it needs to sanity check the URLs on startup (without any username/password).
To follow the RFC, we could:
- Take an
webdav.HTTPClientto handle auth - Change OPTIONS to a PROPFIND request with a
DAV:current-user-principalprop - Return the
DAV:current-user-principalprop
There was a problem hiding this comment.
To accomodate for Alps, we could have an intermediate DiscoverContextURL function that follows the RFC up to and not including the PROPFIND request.
emersion
reviewed
Oct 13, 2020
emersion
reviewed
Oct 13, 2020
emersion
requested changes
Oct 13, 2020
|
Sorry about the delay on this, I'll try to get the remaining change sorted this weekend. |
|
7e07625 adds discovery for CalDAV. What's still missing is the TXT DNS record stuff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #30
This is my first time writing Go code, so I apologise in advance for any beginner mistakes I made in this 😃.