Initial ACL implementation #172
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverpool
commented
Oct 8, 2024
Comment on lines
+354
to
+363
| // convenience CurrentUserPrivilegeSet | ||
| var ( | ||
| CurrentUserPrivilegeSetReadOnly = CurrentUserPrivilegeSet{ | ||
| Privilege: []Privilege{NewPrivilege(Read)}, | ||
| } | ||
| CurrentUserPrivilegeSetReadWrite = CurrentUserPrivilegeSet{ | ||
| Privilege: []Privilege{NewPrivilege(Read), NewPrivilege(Write)}, | ||
| } | ||
| ) | ||
|
|
There was a problem hiding this comment.
Well hidden in this huge file 😉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also aiming to support thunderbird (like #170), I took a deeper look at the RFC7344.
Internally I tried to stick to the RFC with a lot of copy/paste:
Externally, I added a
ReadOnlyboolean field toAddressObjectandAddressBook(defaultfalsemeans read-write).@mheers according to my tests, thunderbird is happy with having privileges only on AddressObject and AddressBook (thunderbird also asks privileges on
ListAddressBooks, but seems happy with a 404 propstat at this level).