carddav: switch to one static path layout #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitfehler
force-pushed
the
bitfehler/static-path-layout
branch
from
f5f9723 to
6dacd83
Compare
emersion
reviewed
Aug 31, 2022
carddav/server.go
Outdated
| resourceTypeUserPrincipal resourceType = iota | ||
| resourceTypeAddressBookHomeSet resourceType = iota | ||
| resourceTypeAddressBook resourceType = iota | ||
| resourceTypeAddressObject resourceType = iota |
There was a problem hiding this comment.
Nit: only the first resourceType = iota is necessary, the rest can be omitted.
See emersion#100 for details. Obsoletes emersion#99.
bitfehler
force-pushed
the
bitfehler/static-path-layout
branch
from
6dacd83 to
ddcb9c0
Compare
|
So, if I recall our discussion correctly, going for a static path layout is probably the most agreeable solution of the bunch, is that correct? For this PR, I added the option to define a global prefix (if your webdav root is not |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #100 for details. Obsoletes #99.