Fix missing pin states in clear() and all_on()

emeric-martineau · Mar 23, 2024 · a46ef90 · a46ef90
1 parent 0385b54
commit a46ef90
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 5 deletions.
diff --git a/Cargo.toml b/Cargo.toml
@@ -7,7 +7,7 @@ keywords = ["embedded", "PCF8574", "PCF8575", "Esp32"]
 license = "MIT"
 readme = "README.md"
 repository = "https://github.com/emeric-martineau/pcf857x-simple-rs"
-version = "0.1.0"
+version = "0.1.1"
 edition = "2021"
 
 

diff --git a/src/pcf8574.rs b/src/pcf8574.rs
@@ -32,12 +32,16 @@ where
 
     /// Turn off all pins
     pub fn clear(&mut self) -> Result<(), <I as i2c::Write>::Error> {
-        self.i2c.write(self.address, &[0])
+        self.i2c.write(self.address, &[0])?;
+        self.pins_state = 0;
+        Ok(())
     }
 
     /// Turn on all pins
     pub fn all_on(&mut self) -> Result<(), <I as i2c::Write>::Error> {
-        self.i2c.write(self.address, &[0xff])
+        self.i2c.write(self.address, &[0xff])?;
+        self.pins_state = 0xff;
+        Ok(())
     }
 
     /// Send two bytes

diff --git a/src/pcf8575.rs b/src/pcf8575.rs
@@ -30,12 +30,16 @@ where
 
     /// Turn off all pins
     pub fn clear(&mut self) -> Result<(), <I as i2c::Write>::Error> {
-        self.i2c.write(self.address, &[0, 0])
+        self.i2c.write(self.address, &[0, 0])?;
+        self.pins_state = 0;
+        Ok(())
     }
 
     /// Turn on all pins
     pub fn all_on(&mut self) -> Result<(), <I as i2c::Write>::Error> {
-        self.i2c.write(self.address, &[0xff, 0xff])
+        self.i2c.write(self.address, &[0xff, 0xff])?;
+        self.pins_state = 0xffff;
+        Ok(())
     }
 
     /// Send two bytes