Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

problem: amount field max value is not rebalancing #1370

Merged
merged 2 commits into from
Dec 31, 2023

Conversation

BOOMER74
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Dec 29, 2023

Codecov Report

Attention: 50 lines in your changes are missing coverage. Please review.

Comparison is base (1a9179d) 35.09% compared to head (198f756) 35.05%.
Report is 2 commits behind head on master.

Files Patch % Lines
.../transaction/SetupTransaction/SetupTransaction.tsx 0.00% 13 Missing and 4 partials ⚠️
...ackages/core/src/transaction/workflow/TxBuilder.ts 7.69% 10 Missing and 2 partials ⚠️
...SetupTransaction/flow/components/ApproveAmount.tsx 0.00% 5 Missing and 1 partial ⚠️
...src/txstash/handler/blockchain/ethereum/prepare.ts 14.28% 4 Missing and 2 partials ⚠️
...saction/workflow/create-tx/CreateErc20ApproveTx.ts 55.55% 4 Missing ⚠️
...saction/flow/blockchain/ethereum/erc20/convert.tsx 0.00% 2 Missing ⚠️
...saction/flow/blockchain/ethereum/erc20/approve.tsx 0.00% 1 Missing ⚠️
...pTransaction/flow/blockchain/ethereum/recovery.tsx 0.00% 1 Missing ⚠️
...ct-app/src/wallets/WalletDetails/WalletBalance.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1370      +/-   ##
==========================================
- Coverage   35.09%   35.05%   -0.04%     
==========================================
  Files         509      509              
  Lines       10244    10266      +22     
  Branches     1331     1335       +4     
==========================================
+ Hits         3595     3599       +4     
- Misses       5427     5441      +14     
- Partials     1222     1226       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@splix splix merged commit 978132d into master Dec 31, 2023
8 of 11 checks passed
@splix splix deleted the fix/amount-field-rebalance branch December 31, 2023 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants