Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

problem: receive disabled entries listed in allowances #1356

Merged
merged 5 commits into from
Dec 20, 2023

Conversation

BOOMER74
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Attention: 223 lines in your changes are missing coverage. Please review.

Comparison is base (2064105) 35.22% compared to head (4d130f4) 35.70%.

Files Patch % Lines
...pTransaction/flow/blockchain/ethereum/recovery.tsx 0.00% 38 Missing and 6 partials ⚠️
...ackages/core/src/transaction/workflow/TxBuilder.ts 5.88% 22 Missing and 10 partials ⚠️
...src/txstash/handler/blockchain/ethereum/prepare.ts 9.09% 23 Missing and 7 partials ⚠️
...ct-app/src/wallets/WalletDetails/WalletBalance.tsx 0.00% 21 Missing and 7 partials ⚠️
.../wallets/WalletDetails/entry/EthereumEntryItem.tsx 0.00% 10 Missing and 1 partial ⚠️
...saction/flow/blockchain/ethereum/erc20/approve.tsx 0.00% 9 Missing ⚠️
...SetupTransaction/flow/components/ApproveAmount.tsx 0.00% 8 Missing ⚠️
...app/src/transaction/SetupTransaction/flow/flow.tsx 0.00% 3 Missing and 5 partials ⚠️
...saction/flow/blockchain/ethereum/erc20/convert.tsx 0.00% 5 Missing ⚠️
...action/SetupTransaction/flow/components/Amount.tsx 0.00% 4 Missing and 1 partial ⚠️
... and 24 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1356      +/-   ##
==========================================
+ Coverage   35.22%   35.70%   +0.47%     
==========================================
  Files         512      504       -8     
  Lines       10288    10086     -202     
  Branches     1324     1314      -10     
==========================================
- Hits         3624     3601      -23     
+ Misses       5450     5280     -170     
+ Partials     1214     1205       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@splix splix merged commit 66e67e4 into master Dec 20, 2023
9 of 11 checks passed
@splix splix deleted the fix/allowance-entries branch December 20, 2023 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants