Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solution: common class for new tx ui #1355

Merged
merged 4 commits into from
Dec 20, 2023
Merged

Conversation

BOOMER74
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (9e39594) 35.48% compared to head (2fdaf6e) 35.71%.

Files Patch % Lines
...saction/flow/blockchain/ethereum/erc20/approve.tsx 0.00% 4 Missing ⚠️
...saction/flow/blockchain/ethereum/erc20/convert.tsx 0.00% 4 Missing ⚠️
...pTransaction/flow/blockchain/ethereum/recovery.tsx 0.00% 3 Missing ⚠️
.../transaction/SetupTransaction/flow/common/index.ts 0.00% 1 Missing ⚠️
...ransaction/SetupTransaction/flow/common/modify.tsx 0.00% 1 Missing ⚠️
...app/src/transaction/SetupTransaction/flow/types.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1355      +/-   ##
==========================================
+ Coverage   35.48%   35.71%   +0.22%     
==========================================
  Files         505      504       -1     
  Lines       10149    10084      -65     
  Branches     1317     1314       -3     
==========================================
  Hits         3601     3601              
+ Misses       5340     5278      -62     
+ Partials     1208     1205       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@splix splix merged commit a4b9fef into master Dec 20, 2023
9 of 11 checks passed
@splix splix deleted the feature/new-tx-ui-common-class branch December 20, 2023 01:06
@BOOMER74 BOOMER74 added this to the v2.11.0 milestone Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants