Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solution: new ui for recovery tx #1354

Merged
merged 3 commits into from
Dec 19, 2023

solution: add missing field in prepare tx test

b0040b0
Select commit
Loading
Failed to load commit list.
Merged

solution: new ui for recovery tx #1354

solution: add missing field in prepare tx test
b0040b0
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 19, 2023 in 1s

35.48% (+0.25%) compared to 2064105

View this Pull Request on Codecov

35.48% (+0.25%) compared to 2064105

Details

Codecov Report

Attention: 225 lines in your changes are missing coverage. Please review.

Comparison is base (2064105) 35.22% compared to head (b0040b0) 35.48%.

Files Patch % Lines
...pTransaction/flow/blockchain/ethereum/recovery.tsx 0.00% 51 Missing and 7 partials ⚠️
...ackages/core/src/transaction/workflow/TxBuilder.ts 5.88% 22 Missing and 10 partials ⚠️
...src/txstash/handler/blockchain/ethereum/prepare.ts 9.09% 23 Missing and 7 partials ⚠️
...ct-app/src/wallets/WalletDetails/WalletBalance.tsx 0.00% 21 Missing and 7 partials ⚠️
.../wallets/WalletDetails/entry/EthereumEntryItem.tsx 0.00% 10 Missing and 1 partial ⚠️
...SetupTransaction/flow/components/ApproveAmount.tsx 0.00% 8 Missing ⚠️
...app/src/transaction/SetupTransaction/flow/flow.tsx 0.00% 3 Missing and 5 partials ⚠️
...saction/flow/blockchain/ethereum/erc20/approve.tsx 0.00% 5 Missing ⚠️
...action/SetupTransaction/flow/components/Amount.tsx 0.00% 4 Missing and 1 partial ⚠️
...ct-app/src/wallets/WalletDetails/WalletDetails.tsx 0.00% 4 Missing and 1 partial ⚠️
... and 21 more
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1354      +/-   ##
==========================================
+ Coverage   35.22%   35.48%   +0.25%     
==========================================
  Files         512      505       -7     
  Lines       10288    10149     -139     
  Branches     1324     1317       -7     
==========================================
- Hits         3624     3601      -23     
+ Misses       5450     5340     -110     
+ Partials     1214     1208       -6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov