Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solution: unify create tx ui #1344

Merged
merged 6 commits into from
Nov 14, 2023
Merged

solution: unify create tx ui #1344

merged 6 commits into from
Nov 14, 2023

Conversation

BOOMER74
Copy link
Contributor

@BOOMER74 BOOMER74 commented Nov 3, 2023

No description provided.

@BOOMER74 BOOMER74 added this to the v2.11.0 milestone Nov 3, 2023
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Attention: 794 lines in your changes are missing coverage. Please review.

Comparison is base (1495237) 30.34% compared to head (7e10586) 30.94%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1344      +/-   ##
==========================================
+ Coverage   30.34%   30.94%   +0.60%     
==========================================
  Files         475      486      +11     
  Lines       10652    10235     -417     
  Branches     1428     1363      -65     
==========================================
- Hits         3232     3167      -65     
+ Misses       6082     5793     -289     
+ Partials     1338     1275      -63     
Files Coverage Δ
packages/core/src/workflow/CreateErc20ApproveTx.ts 75.43% <100.00%> (ø)
packages/core/src/workflow/CreateErc20WrappedTx.ts 44.18% <100.00%> (ø)
packages/react-app/src/common/BtcConfirm/RawTx.tsx 0.00% <ø> (ø)
...s/react-app/src/common/BtcConfirm/RawTxDetails.tsx 0.00% <ø> (ø)
...react-app/src/common/StoredTxView/StoredTxView.tsx 100.00% <ø> (ø)
...ackages/react-app/src/common/StoredTxView/index.ts 100.00% <100.00%> (ø)
.../src/transaction/BroadcastEthTx/BroadcastEthTx.tsx 57.50% <ø> (ø)
...ateApproveTransaction/CreateApproveTransaction.tsx 0.00% <ø> (ø)
...ateConvertTransaction/CreateConvertTransaction.tsx 0.00% <ø> (ø)
...ateRecoverTransaction/CreateRecoverTransaction.tsx 0.00% <ø> (ø)
... and 81 more

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BOOMER74 BOOMER74 marked this pull request as ready for review November 7, 2023 15:19
@splix splix merged commit ff97d20 into master Nov 14, 2023
8 of 10 checks passed
@splix splix deleted the feature/unified-create-tx-ui branch November 14, 2023 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants