Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solution: new create tx logic and components #1341

Merged
merged 2 commits into from
Oct 23, 2023
Merged

Conversation

BOOMER74
Copy link
Contributor

No description provided.

@BOOMER74 BOOMER74 added this to the v2.11.0 milestone Oct 19, 2023
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Attention: 719 lines in your changes are missing coverage. Please review.

Comparison is base (f0a72f7) 31.40% compared to head (cc7fc75) 30.35%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1341      +/-   ##
==========================================
- Coverage   31.40%   30.35%   -1.05%     
==========================================
  Files         446      475      +29     
  Lines        9923    10647     +724     
  Branches     1333     1427      +94     
==========================================
+ Hits         3116     3232     +116     
- Misses       5559     6078     +519     
- Partials     1248     1337      +89     
Files Coverage Δ
packages/core/src/blockchains/blockchains.ts 61.76% <ø> (+2.94%) ⬆️
packages/core/src/transaction/ethereum.ts 71.42% <ø> (ø)
...ges/core/src/workflow/create-tx/CreateBitcoinTx.ts 81.63% <ø> (-0.19%) ⬇️
packages/core/src/workflow/create-tx/types.ts 80.00% <ø> (ø)
packages/core/src/workflow/index.ts 100.00% <100.00%> (ø)
...ckages/react-app/src/common/EthTxSettings/index.ts 100.00% <100.00%> (ø)
...s/react-app/src/common/SelectAsset/SelectAsset.tsx 77.77% <100.00%> (ø)
...es/react-app/src/transaction/CreateTx/CreateTx.tsx 64.81% <100.00%> (ø)
...react-app/src/transactions/TxDetails/TxDetails.tsx 60.31% <ø> (ø)
packages/store/src/index.ts 100.00% <100.00%> (ø)
... and 52 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BOOMER74 BOOMER74 marked this pull request as ready for review October 20, 2023 15:01
@splix splix merged commit 1495237 into master Oct 23, 2023
@splix splix deleted the feature/new-create-tx branch October 23, 2023 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants