-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix open issues in doc generation #7
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AVHopp
commented
Nov 29, 2023
AVHopp
commented
Nov 29, 2023
Merged
Scienfitz
requested changes
Nov 29, 2023
AVHopp
changed the title
Prevent doc building from failing after encountering an error
Fix open issues in doc generation
Nov 29, 2023
AVHopp
force-pushed
the
docs/debug_documentation_building
branch
from
November 29, 2023 12:15
af110e3
to
f3756af
Compare
AVHopp
commented
Nov 29, 2023
AVHopp
commented
Nov 29, 2023
AdrianSosic
previously approved these changes
Nov 29, 2023
Scienfitz
requested changes
Nov 29, 2023
AVHopp
force-pushed
the
docs/debug_documentation_building
branch
from
November 29, 2023 16:53
f3756af
to
38fd909
Compare
Scienfitz
approved these changes
Nov 29, 2023
AdrianSosic
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prevents the documentation building from failing when encountering an error.
This is achieved by replacing the
check_call
commands byrun
in case of an error that is raised.