Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix open issues in doc generation #7

Merged
merged 4 commits into from
Nov 29, 2023

Conversation

AVHopp
Copy link
Collaborator

@AVHopp AVHopp commented Nov 29, 2023

This PR prevents the documentation building from failing when encountering an error.

This is achieved by replacing the check_call commands by run in case of an error that is raised.

@Scienfitz Scienfitz mentioned this pull request Nov 29, 2023
@AVHopp AVHopp requested a review from AdrianSosic November 29, 2023 10:45
@AVHopp AVHopp self-assigned this Nov 29, 2023
CHANGELOG.md Outdated Show resolved Hide resolved
@AVHopp AVHopp changed the title Prevent doc building from failing after encountering an error Fix open issues in doc generation Nov 29, 2023
@AVHopp AVHopp force-pushed the docs/debug_documentation_building branch from af110e3 to f3756af Compare November 29, 2023 12:15
tox.ini Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
AdrianSosic
AdrianSosic previously approved these changes Nov 29, 2023
README.md Outdated Show resolved Hide resolved
@AdrianSosic AdrianSosic merged commit f2c9acb into main Nov 29, 2023
7 checks passed
@AdrianSosic AdrianSosic deleted the docs/debug_documentation_building branch November 29, 2023 19:43
@AdrianSosic AdrianSosic added the documentation Improvements or additions to documentation label Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants