Fix empty constraints after dropping parameters #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scienfitz
approved these changes
Dec 10, 2024
AVHopp
force-pushed
the
fix/empty_constraints_after_cardinality_constraints
branch
from
5c30995 to
a761b9d
Compare
AdrianSosic
approved these changes
Dec 11, 2024
There was a problem hiding this comment.
Hi @AVHopp, thanks for the PR! I've made some minor modifications, mostly making the condition more readable. Feel free to merge 🚀
AVHopp
force-pushed
the
fix/empty_constraints_after_cardinality_constraints
branch
from
b1cf2ef to
b28db43
Compare
AVHopp
deleted the
fix/empty_constraints_after_cardinality_constraints
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When dropping parameters due to the use of cardinality constraints, it can happen that an attempt is made to create a Constraint without any parameters, causing the code to crash.
This PR introduces an explicit test for this scenario as well as a fix by only including constraints that still have parameters after dropping them.
This was observed when working on #345 and is necessary for continuing working on that.