-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix parameter value conversion #259
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
converted to draft until corresponding |
AdrianSosic
added
the
on hold
PR progress is awaiting for something else to continue
label
Jul 3, 2024
AdrianSosic
force-pushed
the
bugfix/task_parameter
branch
from
August 3, 2024 20:03
d2fdb33
to
0ad7134
Compare
AdrianSosic
removed
the
on hold
PR progress is awaiting for something else to continue
label
Aug 3, 2024
AdrianSosic
force-pushed
the
bugfix/task_parameter
branch
from
August 3, 2024 20:08
0ad7134
to
ad2d74c
Compare
AVHopp
approved these changes
Aug 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just minor questions, plus: Does this require a CHANGELOG update?
AdrianSosic
commented
Aug 5, 2024
AdrianSosic
force-pushed
the
bugfix/task_parameter
branch
from
August 7, 2024 06:48
95d0830
to
9936e92
Compare
AdrianSosic
force-pushed
the
bugfix/task_parameter
branch
from
August 21, 2024 07:32
9936e92
to
8c6bf8d
Compare
The new feature is not yet supported by type checkers
AdrianSosic
force-pushed
the
bugfix/task_parameter
branch
from
August 21, 2024 08:00
8c6bf8d
to
dc1cc7c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #171 using the new 3-argument converters available in
attrs==0.24.1
.