Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parameter value conversion #259

Merged
merged 6 commits into from
Aug 21, 2024
Merged

Fix parameter value conversion #259

merged 6 commits into from
Aug 21, 2024

Conversation

AdrianSosic
Copy link
Collaborator

@AdrianSosic AdrianSosic commented Jun 4, 2024

Fixes #171 using the new 3-argument converters available in attrs==0.24.1.

@AdrianSosic AdrianSosic added the bug Something isn't working label Jun 4, 2024
@AdrianSosic AdrianSosic self-assigned this Jun 4, 2024
@Scienfitz Scienfitz marked this pull request as draft June 4, 2024 15:05
@Scienfitz
Copy link
Collaborator

converted to draft until corresponding attrs version is actually live

@AdrianSosic AdrianSosic added the on hold PR progress is awaiting for something else to continue label Jul 3, 2024
@AdrianSosic AdrianSosic force-pushed the bugfix/task_parameter branch from d2fdb33 to 0ad7134 Compare August 3, 2024 20:03
@AdrianSosic AdrianSosic marked this pull request as ready for review August 3, 2024 20:03
@AdrianSosic AdrianSosic removed the on hold PR progress is awaiting for something else to continue label Aug 3, 2024
@AdrianSosic AdrianSosic force-pushed the bugfix/task_parameter branch from 0ad7134 to ad2d74c Compare August 3, 2024 20:08
Copy link
Collaborator

@AVHopp AVHopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor questions, plus: Does this require a CHANGELOG update?

baybe/utils/conversion.py Show resolved Hide resolved
baybe/parameters/numerical.py Show resolved Hide resolved
@AdrianSosic AdrianSosic force-pushed the bugfix/task_parameter branch from 95d0830 to 9936e92 Compare August 7, 2024 06:48
@AdrianSosic AdrianSosic force-pushed the bugfix/task_parameter branch from 9936e92 to 8c6bf8d Compare August 21, 2024 07:32
@AdrianSosic AdrianSosic force-pushed the bugfix/task_parameter branch from 8c6bf8d to dc1cc7c Compare August 21, 2024 08:00
@AdrianSosic AdrianSosic merged commit 5d4df5a into main Aug 21, 2024
9 of 11 checks passed
@AdrianSosic AdrianSosic deleted the bugfix/task_parameter branch August 21, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Value conversion for CategoricalParameter and TaskParameter
3 participants