Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Release Pipeline #12

Merged
merged 2 commits into from
Dec 1, 2023
Merged

Add Release Pipeline #12

merged 2 commits into from
Dec 1, 2023

Conversation

Scienfitz
Copy link
Collaborator

since our meeting has moved later and theres not much more time for me to work on it today here already my proposal at the release pipeline

I've tested triggers etc in my fork. PyPI upload actions have only been uncommented here. This pipe is safe to use and will only fully work once we add the secrets

Copy link
Collaborator

@AdrianSosic AdrianSosic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Scienfitz, thanks for handling this. Looking gucci, I pretty much have much more trust in you with the pipelines than in myself anyway, after all your work on Azure 🥇

Two open questions:

  1. I think the two-step approach could really be a good idea, given that we cannot remove messed-up things from PyPI. But just to be on the same page: the workflow would then be to manually create an additional release for each tag, right?
  2. Do you want me to create a token already for TestPyPI (since I'm currently the only one with the emdaccount) so that we can give it a full test?

Copy link
Collaborator

@AVHopp AVHopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving such that this can be merged.

sine our meeting has moved later and thres not much more time for me to work on it today here already my proposal at the releas epipeline

Ive tested triggers etc in my fork. PyPI upload actions have only been uncommented here. This pipe is safe to sue and will only fully work once we add the secrets
@Scienfitz Scienfitz force-pushed the repo/release_pipeline branch from 4c06b30 to 677f3b2 Compare December 1, 2023 13:42
@Scienfitz Scienfitz merged commit d4f23c8 into main Dec 1, 2023
8 checks passed
@AdrianSosic AdrianSosic added the repo Requires changes to the project configuration label Dec 4, 2023
@Scienfitz Scienfitz deleted the repo/release_pipeline branch December 4, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
repo Requires changes to the project configuration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants