fixup! Refactor persistence handling: Restructure path building by se…

…parating folder and filename construction. This commit will drop the workflow id to allow overwriting and make the path homogenous constructable.

fix linting

benchmarks/persistence/persistence.py

@@ -15,8 +15,6 @@
 
 from benchmarks import Benchmark, Result
 
-MODULE_WILL_USE_AWS = os.getenv("BAYBE_PERFORMANCE_PERSISTENCE_PATH", None) is not None
-
 
 class PathStrategy(Enum):
     """The way a path extension is constructed."""
@@ -116,7 +114,7 @@ class S3PersistenceHandler:
     @_bucket_name.default
     def _default_bucket_name(self) -> str:
         """Get the bucket name from the environment variables."""
-        if not MODULE_WILL_USE_AWS:
+        if "BAYBE_PERFORMANCE_PERSISTENCE_PATH" not in os.environ:
             raise ValueError("No S3 bucket name provided.")
         return os.getenv(
             "BAYBE_PERFORMANCE_PERSISTENCE_PATH",
@@ -177,6 +175,7 @@ def persister_factory() -> PersistenceHandlingInterface:
     Returns:
         The persistence handler.
     """
+    MODULE_WILL_USE_AWS = "BAYBE_PERFORMANCE_PERSISTENCE_PATH" in os.environ
     if MODULE_WILL_USE_AWS:
         return S3PersistenceHandler()
     return LocalFileSystemPersistenceHandler()