Implement DataSource's new methods: hasList, hasNested, getListOf, and toMap #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d toMap Some methods have been added in Embulk SPI's DataSource: embulk/embulk#1534 It implements them in embulk-util-config's DataSourceImpl.
|
We're going to add unit tests for them. |
Base automatically changed from
test-with-junit-5.10.0-embulk-0.11.1
to
master
November 2, 2023 08:14
dmikurube
force-pushed
the
implement-hasList-hasNested-getListOf-toMap
branch
from
7ef9c6d to
e444178
Compare
hiroyuki-sato
approved these changes
Nov 8, 2023
| } | ||
| fail("ConfigException should be thrown by getting a mixed JSON array as a List of Strings."); | ||
| } | ||
|
|
||
| @Test | ||
| public void testFailToGetNestedAsList() { |
There was a problem hiding this comment.
Just memo reading review
{
"string": "foo",
"boolean": true,
"int": 12,
"double": 42914.142,
"array": [
"hoge",
"fuga",
{
"subkey1": "something"
},
[
"sumewhat"
]
],
"arrayOfStrings": [
"foo",
"bar",
"baz"
],
"arrayOfIntegers": [
124,
-4014,
9241
],
"object": {
"key1": "value1",
"key2": "value2"
}
}
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some methods have been added in Embulk SPI's DataSource: embulk/embulk#1534
It implements them in embulk-util-config's DataSourceImpl.