Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add getDataLength for numeric without precision #351

Merged
merged 2 commits into from
Oct 31, 2024
Merged

Add getDataLength for numeric without precision #351

merged 2 commits into from
Oct 31, 2024

Conversation

shin1103
Copy link
Contributor

This pull request is fixes issue #350

@shin1103 shin1103 requested a review from a team as a code owner October 16, 2024 12:49
@dmikurube
Copy link
Member

Thanks for your contribution!

The change seems good and reasonable, but do you have any reference in the PostgreSQL JDBC Driver that explains the difference? (For example, a pull request, an issue, or a commit in https://github.com/pgjdbc/pgjdbc)

@shin1103 shin1103 force-pushed the fix/numeric-precision-error branch from f4b518b to 5bfe0e8 Compare October 16, 2024 23:40
@shin1103
Copy link
Contributor Author

Thanks for early response.

I wrote why this difference is occurred in issue.
#350 (comment)

@dmikurube
Copy link
Member

Sorry for being late.

Thanks for the pointers. Then, can you include those links and some more background information as a comment there in the code? It'd help us in the future to track the context back.

Then I'll approve this. Also, can I hear your thoughts, @hiroyuki-sato @hito4t ?

@shin1103
Copy link
Contributor Author

Thank you for the response.
Add some comment about getDataLength. Please confirm.

hiroyuki-sato
hiroyuki-sato approved these changes Oct 20, 2024
View reviewed changes
Copy link
Member

@hiroyuki-sato hiroyuki-sato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍 @shin1103 Thank you for creating this PR

dmikurube
dmikurube approved these changes Oct 28, 2024
View reviewed changes
Copy link
Member

@dmikurube dmikurube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for being late again, and thanks for working on it! LGTM2.

Let me wait for @hito4t for more 1-2 days, but will merge soon.

@dmikurube
Copy link
Member

No response since 3 days ago. Let's merge this. Thanks for your contribution!

We'll be releasing v0.10.7 with this, but it may take some more time. Please let us know if you're in a hurry.

@dmikurube dmikurube merged commit 1a04c53 into embulk:master Oct 31, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiroyuki-sato hiroyuki-sato hiroyuki-sato approved these changes

@dmikurube dmikurube dmikurube approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shin1103 @dmikurube @hiroyuki-sato