Merge pull request #325 from joker1007/log-last-exception

Add logging to avoid loss of information when exception changes during retries
embulk · Oct 4, 2023 · 952cae5 · 952cae5
2 parents c2acb83 + 32e152d
commit 952cae5
Showing 1 changed file with 12 additions and 1 deletion.
diff --git a/embulk-output-jdbc/src/main/java/org/embulk/output/jdbc/AbstractJdbcOutputPlugin.java b/embulk-output-jdbc/src/main/java/org/embulk/output/jdbc/AbstractJdbcOutputPlugin.java
@@ -1369,7 +1369,18 @@ public void onGiveup(Exception firstException, Exception lastException)
                 SQLException ex = (SQLException) firstException;
                 String sqlState = ex.getSQLState();
                 int errorCode = ex.getErrorCode();
-                logger.error("{} ({}:{})", errorMessage, errorCode, sqlState);
+                logger.error("{} (first exception:{SQLState={}, ErrorCode={}})", errorMessage, errorCode, sqlState, ex);
+            } else {
+                logger.error("{} (first exception)", errorMessage, firstException);
+            }
+
+            if (lastException instanceof SQLException) {
+                SQLException ex = (SQLException) lastException;
+                String sqlState = ex.getSQLState();
+                int errorCode = ex.getErrorCode();
+                logger.error("{} (last exception:{SQLState={}, ErrorCode={}})", errorMessage, errorCode, sqlState, ex);
+            } else {
+                logger.error("{} (last exception)", errorMessage, lastException);
             }
         }