Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish from GitHub Actions #11

Merged
merged 1 commit into from
May 13, 2024
Merged

Publish from GitHub Actions #11

merged 1 commit into from
May 13, 2024

Conversation

hiroyuki-sato
Copy link
Member

No description provided.

@hiroyuki-sato hiroyuki-sato requested a review from a team as a code owner May 13, 2024 05:26
dmikurube
dmikurube approved these changes May 13, 2024
View reviewed changes
Copy link
Member

@dmikurube dmikurube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dmikurube
Copy link
Member

Ah, but note that the vars and secrets are not yet set.

@hiroyuki-sato
Copy link
Member Author

Thanks. I'll create dependabot PR later. I'll wait to set those parameters

@dmikurube
Copy link
Member

All set.

@hiroyuki-sato hiroyuki-sato merged commit a4736a5 into master May 13, 2024
4 checks passed
@hiroyuki-sato hiroyuki-sato deleted the embulk/github-publish-workflow branch May 13, 2024 08:56
@hiroyuki-sato
Copy link
Member Author

Thanks!

@hiroyuki-sato hiroyuki-sato added this to the v0.2.0 milestone May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmikurube dmikurube dmikurube approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v0.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@hiroyuki-sato @dmikurube