-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add template_table config #25
Conversation
If template_table is set, plugin fetches table schema from it.
This feature and refactored code looks good to me. I'll test at my environment, so please give me a little time. |
@joker1007 @sakama why don't you create BigTable's schema file from Embulk's schema? Output plugins can know schema because input plugin already decided it. |
I mean that template_table seems a good option. Other outputs (such as JDBC) also can have it. But I wonder that's the default. |
@frsyuki |
@frsyuki @joker1007
|
Fmm.. it is slightly hard work. |
I merged. Thanks! |
Merge upstream
If
template_table
is set, plugin fetches table schema from it instead ofschema_path
.the use case is like templateSuffix.
If base table schema is changed, next created table uses new schema.
And, I refactored some methods for this feature.
How about this?