Support description of columns and tables #142
Merged
+12
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fagai Thank you for adding tests. |
|
Hi, maintainers! |
|
Hello, @fagai. I'm a new maintainer. Could you resolve conflict this PR? I'll review this PR. Or, I'll create another PR later. |
|
@hiroyuki-sato I resolved the conflict. |
|
@fagai Thank you for your work!. Does this PR work as you expected? It seems the column is OK. But, the table doesn't set as you expected. What am I wrong? out:
type: bigquery
mode: append
# snip
table: hello_embulk
source_format: NEWLINE_DELIMITED_JSON
column_options:
- name: purchase
description: hogehogehoge12345
description: hogehogecolumn: OK
table: NG??
|
|
@hiroyuki-sato I don't have a deep understanding of ruby, so I may be wrong. |
fagai
force-pushed
the
support_description
branch
from
5ad6da8 to
dd311f5
Compare
|
Thanks LGTM👍 
@joker1007 Could you check this PR when you get a chance? |
hiroyuki-sato
approved these changes
Mar 2, 2024
joker1007
approved these changes
Mar 4, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #127
add tests. and fixed tests.