Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Because TS addons need to emit declarations, we need to set noEmit to false #277

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

NullVoxPopuli
Copy link
Collaborator

@NullVoxPopuli NullVoxPopuli commented Mar 25, 2024

Originally opened in #271


if you add emitDeclarationOnly: true, you get silent fail, (exit 0), no declaration.

if you run tsc --decalaration to get debugging info on the config, you get this error:

❯ tsc --declaration
tsconfig.json:17:5 - error TS5053: Option 'emitDeclarationOnly' cannot be specified with option 'noEmit'.

17     "emitDeclarationOnly": true,
       ~~~~~~~~~~~~~~~~~~~~~


Found 1 error in tsconfig.json:17

We are a bit at-odds with @tsconfig/ember, because it's designed for apps, and libraries just inherently have different needs.


To test locally:

❯ npx [email protected] addon --blueprint ../OpenSource/emberjs/addon-blueprint --pnpm --typescript test-declaration-checking-and-generation

@ef4 ef4 merged commit 8b7e2be into main Mar 26, 2024
18 checks passed
@ef4 ef4 deleted the NullVoxPopuli-patch-3 branch March 26, 2024 15:20
@github-actions github-actions bot mentioned this pull request Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants