Skip to content

Commit

Permalink
Merge pull request #306 from embroider-build/ember-source-is-required…
Browse files Browse the repository at this point in the history
…-for-babel-plugin-ember-template-compilation

ember-source is required for babel-plugin-ember-template-compilation
  • Loading branch information
NullVoxPopuli authored Nov 10, 2024
2 parents 6598c3c + 58d2907 commit 70b3852
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 2 deletions.
4 changes: 4 additions & 0 deletions files/__addonLocation__/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,9 @@
"@embroider/addon-shim": "^1.8.7",
"decorator-transforms": "^2.0.0"
},
"peerDependencies": {
"ember-source": ">= 4.12.0"
},
"devDependencies": {
"@babel/core": "^7.24.4",
<% if (typescript) { %>"@babel/plugin-transform-typescript": "^7.24.4"<% } else { %>"@babel/eslint-parser": "^7.24.1"<% } %>,
Expand Down Expand Up @@ -72,6 +75,7 @@
"@rollup/plugin-babel": "^6.0.4",
"babel-plugin-ember-template-compilation": "^2.2.5",
"concurrently": "^8.2.2",
"ember-source": "^5.4.0",
"ember-template-lint": "^6.0.0",<% if (packageManager === 'npm') { %>
"ember-eslint-parser": "^0.4.2",
<% } %>"eslint": "^8.56.0",
Expand Down
7 changes: 5 additions & 2 deletions index.js
Original file line number Diff line number Diff line change
Expand Up @@ -309,7 +309,11 @@ module.exports = {
let files = this._super.files.apply(this, arguments);

if (options.addonOnly) {
files = files.filter((filename) => filename.includes('__addonLocation__') || filesToCopyFromRootToAddonInAddonOnlyMode.includes(filename));
files = files.filter(
(filename) =>
filename.includes('__addonLocation__') ||
filesToCopyFromRootToAddonInAddonOnlyMode.includes(filename),
);
} else {
// filter out the addon-specific npmrc, as it
// is only applicable during --addon-only
Expand Down Expand Up @@ -386,4 +390,3 @@ function isYarn(options) {
function isNpm(options) {
return options.packageManager === 'npm' || options.npm;
}

0 comments on commit 70b3852

Please sign in to comment.