use esm properly with node

ember-learn · Nov 3, 2023 · bb2ab42 · bb2ab42
1 parent 4f8dabb
commit bb2ab42
Show file tree

Hide file tree

Showing 11 changed files with 552 additions and 1,096 deletions.
diff --git a/generate-local.js b/generate-local.js
@@ -1,10 +1,12 @@
 import chalk from 'chalk';
 import commandExists from 'command-exists';
 import execa from 'execa';
-import { copyFileSync, ensureFileSync, existsSync, removeSync } from 'fs-extra';
+import fsExtra from 'fs-extra';
 import minimist from 'minimist';
 import path from 'path';
 
+const { copyFileSync, ensureFileSync, existsSync, removeSync } = fsExtra;
+
 const docsPath = '../ember-api-docs-data';
 
 const argv = minimist(process.argv.slice(2));
@@ -47,8 +49,8 @@ async function runCmd(cmd, path, args = []) {
  exit(chalk.red('We need yarn installed globally for this script to work'));
  }
 
- let emberProjectPath = path.join(__dirname, '../', 'ember.js');
- let emberDataProjectPath = path.join(__dirname, '../', 'data');
+ let emberProjectPath = path.join('../', 'ember.js');
+ let emberDataProjectPath = path.join('../', 'data');
 
  let checkIfProjectDirExists = dirPath => {
  if (!existsSync(dirPath)) {

diff --git a/index.js b/index.js
@@ -1,7 +1,7 @@
-// eslint-disable-next-line
-require = require('esm')(module /*, options*/)
+import minimist from 'minimist';
+import { apiDocsProcessor } from './main.js';
 
-const argv = require('minimist')(process.argv.slice(2));
+const argv = minimist(process.argv.slice(2));
 
 let possibleProjects = ['ember', 'ember-data'];
 let projects =
@@ -11,5 +11,4 @@ let specificDocsVersion = argv.version ? argv.version : '';
 let runClean = !!argv.clean;
 let noSync = !argv.sync;
 
-const { apiDocsProcessor } = require('./main.js');
 apiDocsProcessor(projects, specificDocsVersion, runClean, noSync);
diff --git a/lib/get-latest-patch-versions.js b/lib/get-latest-patch-versions.js
@@ -1,4 +1,4 @@
-import { groupBy } from 'lodash';
+import { groupBy } from 'lodash-es';
 import semverCompare from 'semver-compare';
 import semverUtils from 'semver-utils';
 

diff --git a/lib/read-docs.js b/lib/read-docs.js
@@ -1,7 +1,7 @@
 import fs from 'fs-extra';
 import glob from 'glob';
 import { dasherize } from 'inflected';
-import { get as deepGet } from 'lodash';
+import { get as deepGet } from 'lodash-es';
 import { getLatestPatchVersions } from './get-latest-patch-versions.js';
 
 const docsPath = '../ember-api-docs-data';

diff --git a/lib/rev-docs.js b/lib/rev-docs.js
@@ -3,7 +3,7 @@ import ora from 'ora';
 import { basename as getFileName } from 'path';
 import { singularize } from 'inflected';
 import path from 'path';
-const glob = require('glob');
+import glob from 'glob';
 
 const docsPath = '../ember-api-docs-data';
 

diff --git a/lib/yuidoc-fixer/emberKnownEntityNames.js b/lib/yuidoc-fixer/emberKnownEntityNames.js
@@ -1,5 +1,10 @@
-import moduleData from 'ember-rfc176-data';
 import keyfinder from 'keyfinder';
-import { uniq } from 'lodash';
+import { uniq } from 'lodash-es';
+import { createRequire } from 'node:module';
+import fs from 'fs-extra';
+
+const require = createRequire(import.meta.url);
+const moduleDataPath = require.resolve('ember-rfc176-data');
+const moduleData = fs.readJsonSync(moduleDataPath);
 
 export const emberKnownEntityNames = uniq(keyfinder(moduleData, 'export'));
diff --git a/lib/yuidoc-fixer/normalize-yui-doc-class-item.js b/lib/yuidoc-fixer/normalize-yui-doc-class-item.js
@@ -1,4 +1,4 @@
-import { toLower } from 'lodash';
+import { toLower } from 'lodash-es';
 import { yuiDocClassItemKeys } from './yui-doc-class-item-keys.js';
 import { emberKnownEntityNames } from './emberKnownEntityNames.js';
 

diff --git a/lib/yuidoc-fixer/yui-doc-class-item-keys.js b/lib/yuidoc-fixer/yui-doc-class-item-keys.js
@@ -1,4 +1,4 @@
-import { without } from 'lodash';
+import { without } from 'lodash-es';
 
 const originalYuiDocClassItemKeys = [
  'async', // bool, custom events can fire the listeners in a setTimeout