Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Covered @codemod-utils and ember-codemod-args-to-signature #1293

Merged
merged 1 commit into from
Aug 2, 2023
Merged

Covered @codemod-utils and ember-codemod-args-to-signature #1293

merged 1 commit into from
Aug 2, 2023

Conversation

ijlee2
Copy link
Member

@ijlee2 ijlee2 commented Aug 2, 2023

Ember Times review template

  • Add your name to top and bottom
  • Put emoji in writeup title
  • Add a short blurb (could be the title) to the beginning
  • Link to external article/repo/etc in paragraph/body text, not just the writeup title (link in writeup title is optional now)
  • Add the contributor in the post in format "FirstName LastName (@githubusername)" linked to their GitHub account
  • Check that all links work

@ijlee2 ijlee2 added the embertimes PR for an Ember Times issue label Aug 2, 2023
@ijlee2 ijlee2 requested a review from a team as a code owner August 2, 2023 07:32
jaredgalanis
jaredgalanis approved these changes Aug 2, 2023
View reviewed changes
Copy link
Member

@jaredgalanis jaredgalanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you ❤️!

@jaredgalanis jaredgalanis merged commit 5828f66 into ember-learn:times-206 Aug 2, 2023
2 checks passed
@ijlee2 ijlee2 deleted the times-206-codemods branch August 2, 2023 10:31
NullVoxPopuli
NullVoxPopuli reviewed Aug 2, 2023
View reviewed changes
content/the-ember-times-issue-206.md
<!-- alex ignore simple -->
`@codemod-utils` encourages taking small and simple steps, as they are key to writing codemods that can be maintained and extended. Isaac, in the talk "[In 1 Year](https://crunchingnumbers.live/2023/07/20/in-1-year)," explained:

> My hope is, we can lower the [entry] barrier enough that, if a person can write a function in Node.js, then they can start writing a codemod.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yaaas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NullVoxPopuli NullVoxPopuli NullVoxPopuli left review comments

@jaredgalanis jaredgalanis jaredgalanis approved these changes

Assignees
No one assigned
Labels
embertimes PR for an Ember Times issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ijlee2 @NullVoxPopuli @jaredgalanis