Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .alexrc #1290

Merged
merged 3 commits into from
Jul 31, 2023
Merged

Update .alexrc #1290

merged 3 commits into from
Jul 31, 2023

Conversation

mansona
Copy link
Member

@mansona mansona commented Jul 26, 2023

The alex checking is always finding false positives, this is intended to reduce the false positives by only catching words that are likely to have an issue 👍

I can't link to the config section directly but you can go to https://github.com/get-alex/alex and search for profanitySureness and read more about it 👍

@netlify
Copy link

netlify bot commented Jul 26, 2023

Deploy Preview for ember-blog ready!

Name Link
🔨 Latest commit 31bed17
🔍 Latest deploy log https://app.netlify.com/sites/ember-blog/deploys/64c14496138dd50008e4ba42
😎 Deploy Preview https://deploy-preview-1290--ember-blog.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

jaredgalanis
jaredgalanis previously approved these changes Jul 26, 2023
@mansona mansona requested a review from a team as a code owner July 26, 2023 12:47
@mansona mansona marked this pull request as draft July 26, 2023 12:47
@probot-autolabeler probot-autolabeler bot added the embertimes PR for an Ember Times issue label Jul 26, 2023
@mansona
Copy link
Member Author

mansona commented Jul 26, 2023

so the problem is that the profanity and the "equality" rule sets are different 😞 there doesn't seem to be any config available to tune the equality ruleset

@mansona mansona dismissed jaredgalanis’s stale review July 26, 2023 16:07

updated implementation

@mansona mansona marked this pull request as ready for review July 26, 2023 16:07
Copy link
Member

@jaredgalanis jaredgalanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@mansona mansona merged commit 2704330 into main Jul 31, 2023
2 checks passed
@mansona mansona deleted the alex-profanity-sureness branch July 31, 2023 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
embertimes PR for an Ember Times issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants