Add ember cli deprecation workflow #1284
Conversation
…ee list of current deprecations. Add to config file.
✅ Deploy Preview for ember-deprecations ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
| { handler: 'silence', matchId: 'ember.built-in-components.import' }, | ||
| { handler: 'silence', matchId: 'this-property-fallback' }, | ||
| ], | ||
| }; |
There was a problem hiding this comment.
You have to manually update this config which kind of sucks.
- Run the tests suite or navigate through the app
- Run
deprecationWorkflow.flushDeprecations()in the console - Copy the output, and paste it in here.
If you fix one of the deprecations, re-run the above, and update this file
|
Yeah, this addon is super helpful when there are a lot of deprecations! Before merging, let's check in with @geneukum who has being doing a bunch of the upgrading. What do you think about adding this? Is there any particular config that would be helpful? |
|
Yeah, this looks like a super useful addition to me as well! I'd be curious which (if any) of the deprecations show up after we merge #1287 and #1279 though. I guess that we may need to just be careful about ordering to make sure that we're not either silencing deprecations that don't need to be silenced or leaving around silences that have been resolved elsewhere? |
I figured this is a great addition to have to help keep track of the deprecations in the app.
If you want to know more about how to use this: https://guides.emberjs.com/release/configuring-ember/handling-deprecations/
Fixing this list of deprecations will/ might help with the upgrade #1272