Guard propertyName in no-jquery-methods

ember-best-practices · Aug 31, 2017 · 991d904 · 991d904
1 parent aa40fad
commit 991d904
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 0 deletions.
diff --git a/lib/rules/no-jquery-methods.js b/lib/rules/no-jquery-methods.js
@@ -62,6 +62,10 @@ module.exports = {
 
       MemberExpression(node) {
         let propertyName = get(node, 'property.name');
+        // If the node doesn't have a name, return early.
+        if (!propertyName) {
+          return;
+        }
         let blackListName = BLACKLIST.includes(propertyName) ? propertyName : false;
         let isThisExpression = get(node, 'object.type').includes('ThisExpression');
 

diff --git a/tests/lib/rules/no-jquery-methods.js b/tests/lib/rules/no-jquery-methods.js
@@ -74,6 +74,24 @@ ruleTester.run('no-jquery-methods', rule, {
           }
         });`,
       options: []
+    },
+    {
+      code: `
+        export default Ember.Component({
+          init() {
+            const myVar = this[this.myProp];
+          }
+        });`,
+      options: [BLACKLISTMETHOD]
+    },
+    {
+      code: `
+        export default Ember.Component({
+          init() {
+            const q = this[\`\${myVar}\`];
+          }
+        });`,
+      options: [BLACKLISTMETHOD]
     }
   ],
   invalid: [