Updated selectEndpointClusterEvents() function to use existing mappin…

…g method dbMapping.map.event
emargolis · Feb 3, 2023 · 24fb9eb · 24fb9eb
1 parent 166c2a0
commit 24fb9eb
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 15 deletions.
diff --git a/src-electron/db/query-endpoint.js b/src-electron/db/query-endpoint.js
@@ -274,7 +274,7 @@ ORDER BY C.CODE
  * @returns promise that resolves into endpoint cluster events
  */
 async function selectEndpointClusterEvents(db, clusterId, endpointTypeId) {
-  let rows = await dbApi.dbAll(
+  return dbApi.dbAll(
     db,
     `
 SELECT
@@ -296,18 +296,7 @@ ORDER BY E.MANUFACTURER_CODE, E.CODE
   `,
     [clusterId, endpointTypeId]
   )
-
-  return rows.map((row) => {
-    return {
-      id: row['EVENT_ID'],
-      name: row['NAME'],
-      code: row['CODE'],
-      clusterId: clusterId,
-      manufacturerCode: row['MANUFACTURER_CODE'],
-      isOptional: dbApi.fromDbBool(row['IS_OPTIONAL']),
-      hexCode: '0x' + bin.int16ToHex(row['CODE']),
-    }
-  })
+  .then((rows) => rows.map(dbMapping.map.event))
 }
 
 /**

diff --git a/src-electron/util/zcl-util.js b/src-electron/util/zcl-util.js
@@ -86,8 +86,8 @@ function eventComparator(a, b) {
   if (a.manufacturerCode < b.manufacturerCode) return -1
   if (a.manufacturerCode > b.manufacturerCode) return 1
 
-  if (a.hexCode < b.hexCode) return -1
-  if (a.hexCode > b.hexCode) return 1
+  if (a.code < b.code) return -1
+  if (a.code > b.code) return 1
 
   return 0
 }