Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move footer to page end #17

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Move footer to page end #17

wants to merge 1 commit into from

Conversation

basteyy
Copy link
Contributor

@basteyy basteyy commented Apr 29, 2022 •
edited
Loading

As discussed in #16

@emareg
Copy link
Owner

emareg commented May 2, 2022

Thanks for the PR but I am not so sure about this one. For me, pages with a height less than 100vh sound like a rare special case. How often is this needed? Furthermore, why did you choose the solution with display: flex over display: grid? I probably would do some more testing before I merge this into master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@basteyy @emareg