Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lsp-ui-doc-glance not auto-hide after focus out from doc frame #727

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kiennq
Copy link
Member

@kiennq kiennq commented Aug 7, 2022

Fix #726
I've reverted part of #711 and done other fixes to get it working again with both lsp-ui-doc-show and lsp-ui-doc-glance sharing a similar implementation.

@Lenbok

@Lenbok
Copy link
Contributor

Lenbok commented Aug 7, 2022

This does not work for me, the window hides as soon as I attempt to set focus into the window.

@kiennq
Copy link
Member Author

kiennq commented Aug 7, 2022

This does not work for me, the window hides as soon as I attempt to set focus into the window.

Are you doing that in overlay instead of doc frame? AFAIK, the overlay doesn't support focus.
For doc frame, you have to move your mouse out of where the doc frame is going to show up else the frame will be dismissed immediately (a limitation of child frame, same reason why posframe has to banish mouse to the top-left corner when its child frame is shown up).

@Lenbok
Copy link
Contributor

Lenbok commented Aug 7, 2022

While I normally use overlay, I am testing with child frame. The position of the mouse makes no difference to me, this still does not work.

@kiennq
Copy link
Member Author

kiennq commented Aug 7, 2022

While I normally use overlay, I am testing with child frame. The position of the mouse makes no difference to me, this still does not work.

Can you take some screencast?
I'm using both Ubuntu/Windows and this change is working fine.

Also, how do you focus on the doc frame? Via keyboard or mouse?
Using mouse is not working if you're invoking the doc frame via keyboard, as mouse move will dismiss the doc frame immediately. After you're focusing on the doc frame, you can use the mouse to scroll though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lsp-ui-doc frame is not hidden after the doc frame is unfocused
2 participants