Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to using TCP mode instead of stdio #4622

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Switch to using TCP mode instead of stdio #4622

wants to merge 1 commit into from

Conversation

dcermak
Copy link
Contributor

@dcermak dcermak commented Nov 25, 2024

TCP mode has proven to be more reliable than stdio and is required for container mode

@github-actions github-actions bot added the client One or more of lsp-mode language clients label Nov 25, 2024
@jcs090218
Copy link
Member

Can you fix the compile error? Thanks!

In lsp-rpm-spec-server-start-fun:
lsp-rpm-spec.el:51:39: Error: Unused lexical argument `port'

@dcermak
Switch to using TCP mode instead of stdio
fe9a4b4 
TCP mode has proven to be more reliable than stdio and is required for container
mode
@dcermak
Copy link
Contributor Author

dcermak commented Nov 25, 2024

Can you fix the compile error? Thanks!

In lsp-rpm-spec-server-start-fun:
lsp-rpm-spec.el:51:39: Error: Unused lexical argument `port'

Yes, should be done now. Sorry, I accidentally hardcoded port 50 🤦

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcs090218 jcs090218 jcs090218 approved these changes

Assignees
No one assigned
Labels
client One or more of lsp-mode language clients
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dcermak @jcs090218