Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A couple minor fixes for Flymake diagnostics #4435

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Commits on Apr 20, 2024

  1. Configuration menu
    Copy the full SHA
    5a20661 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2024

  1. Add a defcustom to control default diagnostic severity.

    Previously, there was a Flycheck specific defcustom, which was used to
    select a default error level for Flycheck.  However, there was nothing
    for Flymake.  Additionally, there were numerous other places in
    lsp-mode which query the severity attribute of the diagnostic, such as
    for statistics, modeline, headerline, etc.  All of these were being
    handled inconsistently, either not at all (causing an error when the
    attribute was not sent by the server), ignoring it when it was
    missing (causing statistics to be inaccurate) or assuming a default of
    error, which might have been different than the Flycheck specific
    configuration, therefore causing an inconsistency in the modeline
    statistics vs what Flycheck would report.
    
    This change creates a common defcustom which is then used anywhere the
    diagnostic severity is needed, but was not provided by the server.
    This should create consistent statistics between the modeline and the
    back-end checkers.  Additionally, the mapping between this defcustom
    and the checker specific values happens in the diagnostic package.
    
    Since this defcustom is used outside of the lsp-diagnostic package, it
    resides in the lsp-mode package and renamed more generally.
    Additionally, the Flycheck specific defcustom has been obsoleted.
    brownts committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    a686a77 View commit details
    Browse the repository at this point in the history