Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MDX support #4141

Merged
merged 2 commits into from
Sep 14, 2023
Merged

MDX support #4141

merged 2 commits into from
Sep 14, 2023

Conversation

themkat
Copy link
Contributor

@themkat themkat commented Aug 18, 2023

Fixes #4129

Uses:
https://github.com/mdx-js/mdx-analyzer/tree/main/packages/language-server

Adds basic MDX support. MDX has no editing mode in Emacs, so I usually just use Markdown mode. That is the main reason for the priority and activation settings here. Found no configuration options, but they might come later.

@github-actions github-actions bot added the client One or more of lsp-mode language clients label Aug 18, 2023
@themkat
Copy link
Contributor Author

themkat commented Sep 13, 2023

@yyoncho or @jcs090218 , any chance to have a look at this soon? 🙂

@jcs090218
Copy link
Member

There are something missing in the PR. You can use #4089 as a reference.

Copy link
Member

@jcs090218 jcs090218 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yyoncho yyoncho merged commit 1f5afbd into emacs-lsp:master Sep 14, 2023
13 of 14 checks passed
@yyoncho
Copy link
Member

yyoncho commented Sep 14, 2023

Thank you!

@themkat themkat deleted the mdx branch September 14, 2023 14:29
nverno added a commit to nverno/lsp-mode that referenced this pull request Oct 16, 2023
* master: (27 commits)
  Rename blacklist to blocklist (emacs-lsp#4173)
  Introduce a function to disable a call for particular method for a server (emacs-lsp#4171)
  Fix `lsp-completion--company-match` freezing emacs-lsp#4192 (emacs-lsp#4193)
  Bump the magik language server to 0.8.1 (emacs-lsp#4195)
  Add configuration to use new experimental ondisk cache for lsp-kotlin (emacs-lsp#4138)
  lsp-erlang: add setting for types on hover (emacs-lsp#4188)
  Make it possible to override lsp-cmake server command (emacs-lsp#4182)
  lsp-erlang: update erlang-language-platform download file names (emacs-lsp#4187)
  clojure: add paredit refactorings
  Fix typo in php-guide.md (emacs-lsp#4183)
  Bump magik language server to 0.8.0 (emacs-lsp#4176)
  Bump elixir-ls version (emacs-lsp#4178)
  Remove unbalanced parenthesis and double-quote in comments (emacs-lsp#4177)
  MDX support (emacs-lsp#4141)
  lsp-erlang: Add semantic token support for erlang-language-platform (emacs-lsp#4166)
  lsp-mode: Fix sending shutdown message (emacs-lsp#4167)
  lsp-erlang: update ELP download file names (emacs-lsp#4165)
  Add Move language client (emacs-lsp#4155)
  Add support for python-lsp-server pyls-isort plugin. (emacs-lsp#4163)
  Updating Crystal LSP (emacs-lsp#4156)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client One or more of lsp-mode language clients documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MDX LSP client support
3 participants