-
-
Notifications
You must be signed in to change notification settings - Fork 892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MDX support #4141
Merged
Merged
MDX support #4141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@yyoncho or @jcs090218 , any chance to have a look at this soon? 🙂 |
There are something missing in the PR. You can use #4089 as a reference. |
jcs090218
approved these changes
Sep 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
yyoncho
approved these changes
Sep 14, 2023
Thank you! |
nverno
added a commit
to nverno/lsp-mode
that referenced
this pull request
Oct 16, 2023
* master: (27 commits) Rename blacklist to blocklist (emacs-lsp#4173) Introduce a function to disable a call for particular method for a server (emacs-lsp#4171) Fix `lsp-completion--company-match` freezing emacs-lsp#4192 (emacs-lsp#4193) Bump the magik language server to 0.8.1 (emacs-lsp#4195) Add configuration to use new experimental ondisk cache for lsp-kotlin (emacs-lsp#4138) lsp-erlang: add setting for types on hover (emacs-lsp#4188) Make it possible to override lsp-cmake server command (emacs-lsp#4182) lsp-erlang: update erlang-language-platform download file names (emacs-lsp#4187) clojure: add paredit refactorings Fix typo in php-guide.md (emacs-lsp#4183) Bump magik language server to 0.8.0 (emacs-lsp#4176) Bump elixir-ls version (emacs-lsp#4178) Remove unbalanced parenthesis and double-quote in comments (emacs-lsp#4177) MDX support (emacs-lsp#4141) lsp-erlang: Add semantic token support for erlang-language-platform (emacs-lsp#4166) lsp-mode: Fix sending shutdown message (emacs-lsp#4167) lsp-erlang: update ELP download file names (emacs-lsp#4165) Add Move language client (emacs-lsp#4155) Add support for python-lsp-server pyls-isort plugin. (emacs-lsp#4163) Updating Crystal LSP (emacs-lsp#4156) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4129
Uses:
https://github.com/mdx-js/mdx-analyzer/tree/main/packages/language-server
Adds basic MDX support. MDX has no editing mode in Emacs, so I usually just use Markdown mode. That is the main reason for the priority and activation settings here. Found no configuration options, but they might come later.