Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Visual Insert affecting one too many lines #1889

Merged
merged 1 commit into from
Apr 21, 2024

Conversation

axelf4
Copy link
Collaborator

@axelf4 axelf4 commented Apr 20, 2024

This fixes a regression caused by commit 004ac4e, where Visual mode "I" repeated the insertion on one too many lines unless at EOB.

This fixes a regression caused by commit
004ac4e, where Visual mode "I"
repeated the insertion on one too many lines unless at EOB.
@axelf4 axelf4 merged commit fe44a56 into emacs-evil:master Apr 21, 2024
6 checks passed
@axelf4 axelf4 deleted the fix-v_I branch April 21, 2024 19:15
@Hi-Angel
Copy link
Contributor

@axelf4 is it just me (being a devel-version Emacs user), or does this commit result in failure to byte-compile Evil?

Upgrade to recent evil from MELPA only compiles part of Evil files, but compiling evil-commands.el fails. Here's a snippet from make compile when run on latest Evil code:

evil-commands.el:2644:2: Error: List contains a loop: (lower-right lower-left upper-left upper-right lower-right lower-left upper-left upper-right lower-right lower-left . #6)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants