Skip to content

Commit

Permalink
ci: check for lack of byte-compilation warnings
Browse files Browse the repository at this point in the history
As part of that we test with latest released Emacs version rather than
snapshot, because we don't want CI to start suddenly failing on
unrelated changes because upstream introduced a new warning/check.
  • Loading branch information
Hi-Angel committed Feb 20, 2024
1 parent d10cea2 commit b61128f
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
- 25.3
- 26.3
- 27.1
- snapshot
- 29.2
steps:
- uses: purcell/setup-emacs@master
with:
Expand Down
5 changes: 3 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,8 @@ compile: $(ELCFILES)
OLDER_EMACS_DEFUNS = "(progn (defun undo-redo ())) (defun minibuffer-history-value()) (defun switch-to-minibuffer())"

$(ELCFILES): %.elc: %.el
$(EMACS) --batch -Q -L . --eval $(OLDER_EMACS_DEFUNS) -f batch-byte-compile $<
$(EMACS) --batch -Q -L . --eval $(OLDER_EMACS_DEFUNS) \
--eval "(setq byte-compile-error-on-warn t)" -f batch-byte-compile $<

# Byte-compile all files in one batch. This is faster than
# compiling each file in isolation, but also less stringent.
Expand Down Expand Up @@ -59,7 +60,7 @@ clean:
# The TAG variable may specify a test tag or a test name:
# make test TAG=repeat
# This will only run tests pertaining to the repeat system.
test:
test: compile
$(EMACS) -nw -Q --batch -L . -l evil-tests.el \
--eval "(evil-tests-initialize '(${TAG}) '(${PROFILER}))"

Expand Down

0 comments on commit b61128f

Please sign in to comment.