#1902 Comment text truncated in sample apps and canvas test files (#1… (

#1906)
elyra-ai · Apr 24, 2024 · eb3dff5 · eb3dff5
1 parent 08a4163
commit eb3dff5
Show file tree

Hide file tree

Showing 32 changed files with 94 additions and 93 deletions.
diff --git a/canvas_modules/harness/src/client/components/custom-canvases/flows/flowsCanvas.json b/canvas_modules/harness/src/client/components/custom-canvases/flows/flowsCanvas.json
@@ -274,7 +274,7 @@
               "width": 175,
               "height": 52,
               "class_name": "d3-comment-rect",
-              "content": "This canvas shows a flow of data processing nodes..",
+              "content": "This canvas shows a flow of data processing nodes.",
               "associated_id_refs": []
             }
           ]

diff --git a/canvas_modules/harness/src/client/components/custom-canvases/logic/logicCanvas.json b/canvas_modules/harness/src/client/components/custom-canvases/logic/logicCanvas.json
@@ -117,8 +117,8 @@
               "id": "0bcaa069-7d21-43a5-ae84-cbc9680cb135",
               "x_pos": 28,
               "y_pos": 36,
-              "width": 175,
-              "height": 76,
+              "width": 196,
+              "height": 84,
               "class_name": "d3-comment-rect",
               "content": "This canvas shows a flow of data processing nodes where enableDetachableLinks is switched on.",
               "associated_id_refs": []

diff --git a/...ess/src/client/components/custom-canvases/react-nodes-carbon/react-nodes-carbon-flow.json b/...ess/src/client/components/custom-canvases/react-nodes-carbon/react-nodes-carbon-flow.json
@@ -475,8 +475,8 @@
               "id": "0bcaa069-7d21-43a5-ae84-cbc9680cb135",
               "x_pos": 55,
               "y_pos": 20,
-              "width": 400,
-              "height": 112,
+              "width": 440,
+              "height": 120,
               "class_name": "bkg-col-green-20",
               "content": "## React Objects Canvas\n\nThis sample app shows the React objects, CardNode and ShapeNode, from the Carbon-Charts library being used to display the body of canvas nodes. The selection highlighting, ports, overflow icon and tip for the nodes are provided by common-canvas.",
               "associated_id_refs": []

diff --git a/.../harness/src/client/components/custom-canvases/stages-card-node/stagesCardNodeCanvas.json b/.../harness/src/client/components/custom-canvases/stages-card-node/stagesCardNodeCanvas.json
@@ -266,7 +266,7 @@
 				"comments": [{
 					"id": "0bcaa069-7d21-43a5-ae84-cbc9680cb135",
 					"x_pos": 0,
-					"y_pos": 21.45,
+					"y_pos": 10,
 					"width": 320,
 					"height": 150.15,
 					"class_name": "d3-comment-rect",

diff --git a/canvas_modules/harness/src/client/components/custom-canvases/stages/stagesCanvas.json b/canvas_modules/harness/src/client/components/custom-canvases/stages/stagesCanvas.json
@@ -261,8 +261,8 @@
               "id": "0bcaa069-7d21-43a5-ae84-cbc9680cb135",
               "x_pos": 18,
               "y_pos": 14.4,
-              "width": 175,
-              "height": 76,
+              "width": 190,
+              "height": 81,
               "class_name": "d3-comment-rect",
               "content": "This canvas shows a flow of data processing nodes where enableDetachableLinks is switched on.",
               "associated_id_refs": []

diff --git a/canvas_modules/harness/test_resources/diagrams/allTypesCanvas.json b/canvas_modules/harness/test_resources/diagrams/allTypesCanvas.json
@@ -448,7 +448,7 @@
               "id": "id42ESQA3VPXB",
               "x_pos": 20,
               "y_pos": 20,
-              "width": 200,
+              "width": 246,
               "height": 64,
               "class_name": "canvas-comment",
               "content": "This canvas shows the 4 different node types and three link types: node links, association links and comments links.",

diff --git a/canvas_modules/harness/test_resources/diagrams/allTypesCanvasBottomTop.json b/canvas_modules/harness/test_resources/diagrams/allTypesCanvasBottomTop.json
@@ -386,7 +386,7 @@
               "id": "id42ESQA3VPXB",
               "x_pos": 32,
               "y_pos": 13.200000000000001,
-              "width": 200,
+              "width": 246,
               "height": 64,
               "class_name": "canvas-comment",
               "content": "This canvas shows the 4 different node types and three link types: node links, association links and comments links.",

diff --git a/canvas_modules/harness/test_resources/diagrams/allTypesCanvasTopBottom.json b/canvas_modules/harness/test_resources/diagrams/allTypesCanvasTopBottom.json
@@ -386,7 +386,7 @@
               "id": "id42ESQA3VPXB",
               "x_pos": 17.5,
               "y_pos": 15,
-              "width": 200,
+              "width": 246,
               "height": 64,
               "class_name": "canvas-comment",
               "content": "This canvas shows the 4 different node types and three link types: node links, association links and comments links.",

diff --git a/canvas_modules/harness/test_resources/diagrams/cardinalityCanvas.json b/canvas_modules/harness/test_resources/diagrams/cardinalityCanvas.json
@@ -360,7 +360,7 @@
               "id": "id42ESQA3VPXB",
               "x_pos": 17.5,
               "y_pos": 15,
-              "width": 200,
+              "width": 228,
               "height": 76,
               "class_name": "canvas-comment",
               "content": "This canvas shows nodes with different cardinalities for testing to make sure links are not crated when maximum cardinalities are hit.",

diff --git a/canvas_modules/harness/test_resources/diagrams/circularFlowsCanvas1.json b/canvas_modules/harness/test_resources/diagrams/circularFlowsCanvas1.json
@@ -423,7 +423,7 @@
               "x_pos": 35,
               "y_pos": 30,
               "width": 437.5,
-              "height": 75,
+              "height": 89,
               "class_name": "d3-comment-rect",
               "content": "This canvas shows examples of circular flows. This allows us to test whether the branch highlighting code can successfully handle such flows. \n\nCircular flows are sometimes encountered by the Streams monitor product. ",
               "associated_id_refs": []

diff --git a/canvas_modules/harness/test_resources/diagrams/circularFlowsCanvas2.json b/canvas_modules/harness/test_resources/diagrams/circularFlowsCanvas2.json
@@ -516,7 +516,7 @@
               "x_pos": 35,
               "y_pos": 30,
               "width": 437.5,
-              "height": 75,
+              "height": 92,
               "class_name": "d3-comment-rect",
               "content": "This canvas shows examples of circular flows. This allows us to test whether the branch highlighting code can successfully handle such flows. \n\nCircular flows are sometimes encountered by the Streams monitor product. ",
               "associated_id_refs": []

diff --git a/canvas_modules/harness/test_resources/diagrams/commentUnderlap.json b/canvas_modules/harness/test_resources/diagrams/commentUnderlap.json
@@ -302,7 +302,7 @@
               "x_pos": 773,
               "y_pos": 49,
               "width": 128,
-              "height": 112,
+              "height": 145,
               "class_name": "canvas-comment",
               "content": " This canvas should show two large boxes each containing 3 nodes. The nodes and links should all appear on top of the comment boxes.",
               "associated_id_refs": []

diff --git a/canvas_modules/harness/test_resources/diagrams/customAttrsCanvas.json b/canvas_modules/harness/test_resources/diagrams/customAttrsCanvas.json
@@ -101,7 +101,7 @@
               "x_pos": 10,
               "y_pos": 10,
               "width": 200,
-              "height": 180,
+              "height": 192,
               "content": "This canvas tests addition of custom attributes to a node. The node on the right has two custom attributes addded to it called data-attr1 and data-attr2. If you look at the dom in the debugger tools you should see them set on the node's image. The node on the right is shown with a faded out image if the data-attr1 custom attribute is applied correctly.",
               "associated_id_refs": []
             }

diff --git a/canvas_modules/harness/test_resources/diagrams/decoratorCanvas.json b/canvas_modules/harness/test_resources/diagrams/decoratorCanvas.json
@@ -673,8 +673,8 @@
               "id": "36ab82d5-b015-47f4-a295-2a8aedabcc21",
               "x_pos": 781,
               "y_pos": 276,
-              "width": 146,
-              "height": 66,
+              "width": 147,
+              "height": 88,
               "class_name": "canvas-comment",
               "content": " This node shows a decorator with a zoom-in image and a yellow background rectangle.",
               "associated_id_refs": [
@@ -689,8 +689,8 @@
               "id": "e81af759-8ceb-4f71-b4ef-e32fa6b5ba79",
               "x_pos": 88,
               "y_pos": 430,
-              "width": 113,
-              "height": 64,
+              "width": 114,
+              "height": 85.00003051757812,
               "class_name": "d3-comment-rect",
               "content": "This node has a decorator at a custom position of x = -10 y = -10",
               "associated_id_refs": [
@@ -706,7 +706,7 @@
               "x_pos": 782,
               "y_pos": 383,
               "width": 164,
-              "height": 40,
+              "height": 50,
               "class_name": "d3-comment-rect",
               "content": "This node has two label decorators",
               "associated_id_refs": [

diff --git a/canvas_modules/harness/test_resources/diagrams/detachedLinksCanvas.json b/canvas_modules/harness/test_resources/diagrams/detachedLinksCanvas.json
@@ -446,9 +446,9 @@
               "x_pos": 17.5,
               "y_pos": 15,
               "width": 237,
-              "height": 76,
+              "height": 128,
               "class_name": "canvas-comment",
-              "content": "This canvas shows examples of detached links. There are three types:\n1. Fully detached\n2. Semi-detached from source node\n3. Semi-detached from target node",
+              "content": "This canvas shows examples of detached links. There are three types:\n1. Fully detached\n2. Semi-detached from source node\n3. Semi-detached from target node\n\nTo see them you must have 'Link Selection' set to 'Detachable'.",
               "associated_id_refs": []
             },
             {

diff --git a/canvas_modules/harness/test_resources/diagrams/errorMarkerCanvas.json b/canvas_modules/harness/test_resources/diagrams/errorMarkerCanvas.json
@@ -280,8 +280,8 @@
               "id": "7480223f-8e7a-4c67-b987-2a31e327545b",
               "x_pos": 56,
               "y_pos": 18,
-              "width": 175,
-              "height": 88,
+              "width": 177,
+              "height": 105,
               "class_name": "d3-comment-rect",
               "content": "This canvas shows examples of different error nodes in both the primary pipeline and also on a supernode and on a node inside a supernode.",
               "associated_id_refs": []

diff --git a/canvas_modules/harness/test_resources/diagrams/externalMainCanvas.json b/canvas_modules/harness/test_resources/diagrams/externalMainCanvas.json
@@ -449,7 +449,7 @@
               "id": "id42ESQA3VPXB",
               "x_pos": 20,
               "y_pos": 20,
-              "width": 199,
+              "width": 233,
               "height": 111.99999237060547,
               "class_name": "canvas-comment",
               "content": "This canvas contains a supernode that references an external pipeline flow. It needs to be opened in the Elyra Canvas test harness which is modified to serve up the external flow in the 'beforeEditaActionHandler' callback.",

diff --git a/canvas_modules/harness/test_resources/diagrams/externalMainCanvasExpanded.json b/canvas_modules/harness/test_resources/diagrams/externalMainCanvasExpanded.json
@@ -449,7 +449,7 @@
               "id": "id42ESQA3VPXB",
               "x_pos": 20,
               "y_pos": 20,
-              "width": 199,
+              "width": 232,
               "height": 111.99999237060547,
               "class_name": "canvas-comment",
               "content": "This canvas contains a supernode that references an external pipeline flow. It needs to be opened in the Elyra Canvas test harness which is modified to serve up the external flow in the 'beforeEditaActionHandler' callback.",