fix: could not see text under debugPC highlight

[eeeXun]

Close #288. This patch has been discussed in #286 (comment). But I think that PR is for dap stuff.

This is the original

This is the fixed

Also, this is reverse turn on in gruvbox setup.

Although we could not see the syntax highlight with lsp or treesitter after this change. I hope one day we could find a better color like #239. Also, thank you for your efforts in maintaining this project.

[eeeXun]

I think the DiffAdd is good enough. How about it

debugPC = { link = "DiffAdd" },

[ellisonleao]

hey @eeeXun can you provide your configs for the plugin please?

[eeeXun]

Do you mean the minimal config? Or just the gruvbox?

[ellisonleao]

@eeeXun gruvbox

[eeeXun]

local colors = require("gruvbox").palette

require("gruvbox").setup({
    contrast = "hard",
    overrides = {
        GruvboxBrightRed = { fg = colors.bright_red },
        GruvboxBrightGreen = { fg = colors.bright_green },
        GruvboxBrightYellow = { fg = colors.bright_yellow },
        GruvboxBrightBlue = { fg = colors.bright_blue },
        GruvboxBrightPurple = { fg = colors.bright_purple },
        GruvboxBrightAqua = { fg = colors.bright_aqua },
        GruvboxBrightOrange = { fg = colors.bright_orange },
        GruvboxFadedRed = { fg = colors.faded_red },
        GruvboxFadedGreen = { fg = colors.faded_green },
        GruvboxFadedYellow = { fg = colors.faded_yellow },
        GruvboxFadedBlue = { fg = colors.faded_blue },
        GruvboxFadedPurple = { fg = colors.faded_purple },
        GruvboxFadedAqua = { fg = colors.faded_aqua },
        GruvboxFadedOrange = { fg = colors.faded_orange },
        GruvboxNeutralRed = { fg = colors.neutral_red },
        GruvboxNeutralGreen = { fg = colors.neutral_green },
        GruvboxNeutralYellow = { fg = colors.neutral_yellow },
        GruvboxNeutralBlue = { fg = colors.neutral_blue },
        GruvboxNeutralPurple = { fg = colors.neutral_purple },
        GruvboxNeutralAqua = { fg = colors.neutral_aqua },
    },
})

[ellisonleao]

@eeeXun out of curiosity, are you using those new highlights anywhere?

[eeeXun]

Do you mean GruvboxBrightRed, GruvboxBrightGreen ...

I only use some of them for bufferline.

bufferline config

require("bufferline").setup({
    options = {
        tab_size = 10,
        numbers = function(opts)
            return string.format("%s·", opts.raise(opts.id))
        end,
        modified_icon = "",
        buffer_close_icon = "",
        show_buffer_icons = false,
        show_close_icon = false,
        indicator = {
            icon = nil,
            style = "none",
        },
        separator_style = { nil, nil },
    },
    highlights = {
        background = {
            bg = { attribute = "fg", highlight = "GruvboxBg0" },
            fg = { attribute = "fg", highlight = "GruvboxFg4" },
        },
        buffer = {
            bg = { attribute = "fg", highlight = "GruvboxBg0" },
            fg = { attribute = "fg", highlight = "GruvboxFg4" },
        },
        buffer_selected = {
            bg = { attribute = "fg", highlight = "GruvboxFg4" },
            fg = { attribute = "fg", highlight = "GruvboxBg0" },
            bold = true,
            italic = false,
        },
        buffer_visible = {
            bg = { attribute = "fg", highlight = "GruvboxBg1" },
            fg = { attribute = "fg", highlight = "GruvboxFg4" },
        },
        close_button = {
            bg = { attribute = "fg", highlight = "GruvboxBg0" },
            fg = { attribute = "fg", highlight = "GruvboxNeutralRed" },
        },
        close_button_selected = {
            bg = { attribute = "fg", highlight = "GruvboxFg4" },
            fg = { attribute = "fg", highlight = "GruvboxNeutralRed" },
        },
        close_button_visible = {
            bg = { attribute = "fg", highlight = "GruvboxBg1" },
            fg = { attribute = "fg", highlight = "GruvboxNeutralRed" },
        },
        duplicate = {
            bg = { attribute = "fg", highlight = "GruvboxBg0" },
            fg = { attribute = "fg", highlight = "GruvboxFg4" },
            bold = true,
        },
        duplicate_selected = {
            bg = { attribute = "fg", highlight = "GruvboxFg4" },
            fg = { attribute = "fg", highlight = "GruvboxBg0" },
            bold = true,
            italic = false,
        },
        duplicate_visible = {
            bg = { attribute = "fg", highlight = "GruvboxBg1" },
            fg = { attribute = "fg", highlight = "GruvboxFg4" },
            bold = true,
        },
        indicator_selected = {
            bg = { attribute = "fg", highlight = "GruvboxFg4" },
            fg = { attribute = "fg", highlight = "GruvboxBg0" },
        },
        indicator_visible = {
            bg = { attribute = "fg", highlight = "GruvboxBg1" },
            fg = { attribute = "fg", highlight = "GruvboxFg4" },
        },
        modified = {
            bg = { attribute = "fg", highlight = "GruvboxBg0" },
            fg = { attribute = "fg", highlight = "GruvboxFadedBlue" },
        },
        modified_selected = {
            bg = { attribute = "fg", highlight = "GruvboxFg4" },
            fg = { attribute = "fg", highlight = "GruvboxFadedBlue" },
        },
        modified_visible = {
            bg = { attribute = "fg", highlight = "GruvboxBg1" },
            fg = { attribute = "fg", highlight = "GruvboxFadedBlue" },
        },
        numbers = {
            bg = { attribute = "fg", highlight = "GruvboxBg0" },
            fg = { attribute = "fg", highlight = "GruvboxFg4" },
        },
        numbers_selected = {
            bg = { attribute = "fg", highlight = "GruvboxFg4" },
            fg = { attribute = "fg", highlight = "GruvboxBg0" },
            bold = true,
            italic = false,
        },
        numbers_visible = {
            bg = { attribute = "fg", highlight = "GruvboxBg1" },
            fg = { attribute = "fg", highlight = "GruvboxFg4" },
        },
        separator = {
            bg = { attribute = "fg", highlight = "GruvboxBg0" },
            fg = { attribute = "fg", highlight = "GruvboxFg4" },
        },
        separator_selected = {
            bg = { attribute = "fg", highlight = "GruvboxFg4" },
            fg = { attribute = "fg", highlight = "GruvboxBg0" },
        },
        separator_visible = {
            bg = { attribute = "fg", highlight = "GruvboxBg1" },
            fg = { attribute = "fg", highlight = "GruvboxFg4" },
        },
    },
})

[eeeXun]

After trying it. I think dark_green is suitable for debugPC. Just like DiffAdd

[eeeXun]

Hi, @ellisonleao . Do you have any consideration for this PR?