Fixed: Performance regression on Faker.Util.pick/1 (#221)

Removed `Enum.to_list/1` call since `Enum.at/2` works fine with any enum. Fixes #213 and fixes #219.
elixirs · Nov 21, 2018 · 85a6ce4 · 85a6ce4
1 parent 9339bb4
commit 85a6ce4
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -18,6 +18,8 @@ Change log itself follows [Keep a CHANGELOG](http://keepachangelog.com) format.
 
 ### Fixed
 
+* `Faker.Util.pick/1` performance regression [[@aptinio][]]
+
 ### Security
 
 ## 0.11.1

diff --git a/lib/faker/util.ex b/lib/faker/util.ex
@@ -27,9 +27,7 @@ defmodule Faker.Util do
   end
 
   def pick(enum) do
-    enum
-    |> Enum.to_list()
-    |> Enum.at(Faker.random_between(0, Enum.count(enum) - 1))
+    Enum.at(enum, Faker.random_between(0, Enum.count(enum) - 1))
   end
 
   @doc """