Retransmit conn checks #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #56 +/- ##
==========================================
+ Coverage 81.79% 82.47% +0.68%
==========================================
Files 25 25
Lines 1483 1518 +35
==========================================
+ Hits 1213 1252 +39
+ Misses 270 266 -4
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
mickel8
force-pushed
the
rtx
branch
2 times, most recently
from
408fd53
to
423686b
Compare
mickel8
force-pushed
the
rtx
branch
2 times, most recently
from
38fc75f
to
9d81512
Compare
LVala
approved these changes
Aug 1, 2024
test/priv/ice_agent_test.exs
Outdated
| @@ -1416,6 +1576,7 @@ defmodule ExICE.Priv.ICEAgentTest do | |||
| assert ice_agent.checklist == %{} | |||
| end | |||
|
|
|||
| @tag :debug | |||
lib/ex_ice/priv/ice_agent.ex
Outdated
| nil -> | ||
| {:ok, {base_addr, base_port}} = ice_agent.transport_module.sockname(tr.socket) | ||
|
|
||
| c = |
There was a problem hiding this comment.
I have nothing against short variable names, but this is a bit extreme.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7