Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create channel #36

Merged
merged 3 commits into from
Apr 15, 2024
Merged

Create channel #36

merged 3 commits into from
Apr 15, 2024

Conversation

mickel8
Copy link
Member

@mickel8 mickel8 commented Apr 13, 2024

No description provided.

Copy link

codecov bot commented Apr 13, 2024

Codecov Report

Merging #36 (8e89a8c) into relay-cand (ecd9883) will increase coverage by 0.32%.
The diff coverage is 97.29%.

Additional details and impacted files
@@              Coverage Diff               @@
##           relay-cand      #36      +/-   ##
==============================================
+ Coverage       79.87%   80.20%   +0.32%     
==============================================
  Files              25       25              
  Lines            1267     1283      +16     
==============================================
+ Hits             1012     1029      +17     
+ Misses            255      254       -1     
Files Coverage Δ
lib/ex_ice/priv/gatherer.ex 95.12% <100.00%> (+0.25%) ⬆️
lib/ex_ice/priv/ice_agent.ex 83.52% <100.00%> (ø)
test/support/transport/mock.ex 78.57% <100.00%> (+2.57%) ⬆️
lib/ex_ice/priv/candidate/relay.ex 88.88% <95.83%> (+6.53%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecd9883...8e89a8c. Read the comment docs.

@mickel8 mickel8 force-pushed the channels branch 2 times, most recently from 8a86023 to fc6a569 Compare April 14, 2024 08:48
@mickel8 mickel8 marked this pull request as ready for review April 14, 2024 08:49
@mickel8 mickel8 requested a review from LVala April 15, 2024 07:06
lib/ex_ice/priv/gatherer.ex Outdated Show resolved Hide resolved
Base automatically changed from relay-cand-test to relay-cand April 15, 2024 13:06
@mickel8 mickel8 merged commit d1517bb into relay-cand Apr 15, 2024
4 checks passed
@mickel8 mickel8 deleted the channels branch April 15, 2024 13:14
mickel8 added a commit that referenced this pull request Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants