Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use detected chrome path as default #740

Merged
merged 4 commits into from
Jul 25, 2023

Conversation

dvic
Copy link
Contributor

@dvic dvic commented Jul 24, 2023

Fixes #739

@dvic
Copy link
Contributor Author

dvic commented Jul 24, 2023

@mhanberg I just modified the default_capabilities and only setting the binary option if the detection was successful.

@dvic
Copy link
Contributor Author

dvic commented Jul 24, 2023

Oops :) This breaks some tests. Looking into it.

@dvic
Copy link
Contributor Author

dvic commented Jul 24, 2023

It seems like System.find_executable returns google-chrome and not a path, I tested this on my own repo (using github action ssh debug) and it should return

iex(1)> System.find_executable("google-chrome")
"/usr/bin/google-chrome"
iex(2)> :os.type
{:unix, :linux}

@dvic dvic force-pushed the put-default-chrome-binary branch from 9d4b669 to 7359523 Compare July 24, 2023 14:51
@dvic
Copy link
Contributor Author

dvic commented Jul 24, 2023

Ok I think I found it 🤞: 7359523

@dvic
Copy link
Contributor Author

dvic commented Jul 24, 2023

🥳 it's fixed

@mhanberg
Copy link
Member

i'll be able to take a closer look at this tonight, thanks!

@mhanberg mhanberg merged commit 1b164ec into elixir-wallaby:main Jul 25, 2023
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chromedriver 115.0.5790.102 not working
2 participants