Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chrome headless and binary opts can be passed in @sessions #736

Merged
merged 2 commits into from
Jul 12, 2023

Conversation

dvic
Copy link
Contributor

@dvic dvic commented Jul 11, 2023

This makes it possible to override headless and binary for a particular test, e.g.,

@sessions [[headless: false]]
feature "my feature", %{session: session} do 
  ...
end

@mhanberg
Copy link
Member

Can you edit the Wallaby.Feature docs to mention you can pass these options?

@dvic
Copy link
Contributor Author

dvic commented Jul 12, 2023

Can you edit the Wallaby.Feature docs to mention you can pass these options?

Done!

lib/wallaby/feature.ex Outdated Show resolved Hide resolved
@mhanberg
Copy link
Member

Have you tested this locally with a real project?

@dvic
Copy link
Contributor Author

dvic commented Jul 12, 2023

Have you tested this locally with a real project?

Yup

@mhanberg mhanberg merged commit 389d416 into elixir-wallaby:main Jul 12, 2023
8 of 10 checks passed
@mhanberg
Copy link
Member

Thanks!

@dvic dvic deleted the chrome-opts-override branch July 12, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants