Add Plug.Static tests #1236
Add Plug.Static tests #1236
Conversation
thymusvulgaris
commented
Jun 26, 2024
•
thymusvulgaris
commented
- Add test that asserts Plug.Static.call/2 serves files from the app directory using a :from with an application name and directory.
test/plug/static_test.exs
Outdated
|
|
||
| test "init/1 transforms an application name :from to a two-tuple :from with the application name and a directory" do | ||
| assert %{from: {:foo, "priv/static"}} = Plug.Static.init(at: "/", from: :foo) | ||
| end |
There was a problem hiding this comment.
Thank you. I am not sure those tests are useful, because they are pretty much testing internals. However, I assume you wrote them to get full coverage, is that correct?
There was a problem hiding this comment.
Indeed, that was the goal.
There was a problem hiding this comment.
I agree with José, init/1 is a callback that only makes sense together with call/2. Testing what init/1 returns is not important because anyway the important part is that then call/2 can accept what init/1 returns. So this is definitely testing internals IMO.
There was a problem hiding this comment.
Thanks for the feedback.
Is there a resource that could help me understand this approach?
There was a problem hiding this comment.
I don't have anything off the top of my head but searching for "black-box testing" for example could lead to some good resources.
There was a problem hiding this comment.
Thank you. Does the remaining test also come under the above? I'm happy to close this PR if so :)
* Add test that asserts Plug.Static.call/2 serves files from the app directory using a :from with an application name and directory.
thymusvulgaris
force-pushed
the
plug-static-tests
branch
from
612a289
to
daced30
Compare
|
💚 💙 💜 💛 ❤️ |
