Add Plug.BasicAuth test #1232
Merged
Add Plug.BasicAuth test #1232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
thymusvulgaris
commented
Jun 24, 2024
thymusvulgaris
commented
- Add test that asserts Plug.BasicAuth.basic_auth/2 raises key error when no options are given and default options are used.
* Add test that asserts Plug.BasicAuth.basic_auth/2 raises key error when no options are given and default options are used.
whatyouhide
approved these changes
Jun 24, 2024
|
Let's go ahead and merge this since @whatyouhide approved but I don't think we are gaining anything by testing these particular error cases :) |
|
💚 💙 💜 💛 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.