Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix iteration counts #572

Merged
merged 1 commit into from
May 14, 2024
Merged

Fix iteration counts #572

merged 1 commit into from
May 14, 2024

Conversation

seanmor5
Copy link
Contributor

@seanmor5 seanmor5 commented May 10, 2024

There was an issue where we were only ever keeping tracking of total iteration completed/started events. This would lead to weird cases like the one described in #531 because the filters looked at total counts, but sometimes we really just care about per-epoch event counts. Rather than favor one over the other, we track both total and epoch iteration counts and allow filtering on both.

Resolves #531

@seanmor5 seanmor5 merged commit f3d5bf9 into main May 14, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in training loops batch count
1 participant