Replace Erlang unicode with iconv in hot code path #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please excuse the big diff on |
|
Hi, thank you for contributing! I would like to check if there are any performance issues in case nif is accessed from more than one process. Did you try using/compiling this in Windows OS? |
|
Actually, that's a good point - we've just been using Linux. |
|
this is solved with rust encoding NIF in support-1.1 tho requires some additional work for input parameters |
|
closed in favor to #86 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all, we use
tdsto query datasets with lots ofNVARCHAR(MAX)data and discovered a performance issue inTds.Types.decode_nchar/1. By replacing Erlangunicodewith theiconvhex, the performance was massively improved without any other code changes (tests are passing).