-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(decrypt): add integration tests #26
Conversation
Reviewer's Guide by SourceryThis pull request adds integration tests for decrypt.py, ensuring that the decryption functionality works as expected. It also refactors some test utilities and fixtures for better code organization and reusability. Additionally, a minor change was made to the error message in decrypt.py to include the file name instead of the full path. File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @athith-g - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟡 Testing: 5 issues found
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
Adds integration tests for decrypt.py.
Also:
INPUT_DIR
andINPUT_TEXT
toutils.py
(references in other files to these constants will be changed in separate PR)fixture_encrypted_files
toconftest.py
(Usage in test_decrypt.py will be removed in separate PR)hello3.c4gh
file that was encrypted withbob.pk
for use in integration testSummary by Sourcery
Add integration tests for decrypt.py and refactor test utilities and fixtures for better organization and reusability.
Enhancements:
Tests: