Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(contributors): add Twitter & Mastodon icons #111

Merged
merged 3 commits into from
Feb 23, 2024
Merged

feat(contributors): add Twitter & Mastodon icons #111

merged 3 commits into from
Feb 23, 2024

Conversation

valens200
Copy link
Contributor

No description provided.

@valens200 valens200 requested review from anuragxxd and a user February 6, 2024 19:50
@vercel Vercel
Copy link

vercel bot commented Feb 6, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
landing-page ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 23, 2024 4:35pm

@uniqueg uniqueg changed the title fix: twitter icons on landing page contributors feat(contributors): add Twitter icons Feb 11, 2024
@uniqueg uniqueg removed the request for review from a user February 11, 2024 11:57
uniqueg
uniqueg requested changes Feb 11, 2024
View reviewed changes
Copy link
Member

@uniqueg uniqueg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @valens200.

It looks nice enough in the preview. However, two issues:

  • Twitter is now called X, and - more importantly - has a new logo; so could you please try to update the logo and use of the word Twitter?
  • Any chance to include Mastodon in this PR as well? That way you could close issues feat(contributors): add Twitter & Mastodon icons #102 with this one PR...

@valens200
Copy link
Contributor Author

Thank you for the feed back @uniqueg , I have fixed that and ready to move on next issues.

anuragxxd
anuragxxd previously approved these changes Feb 19, 2024
View reviewed changes
Copy link
Member

@anuragxxd anuragxxd left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! But as told by @uniqueg maybe you can add Mastodon icons too here! Thanks for the contribution :)

@valens200 valens200 enabled auto-merge (squash) February 19, 2024 17:59
@uniqueg
Copy link
Member

uniqueg commented Feb 23, 2024 •
edited
Loading

Hi @valens200 - did you take care of the Mastodon? I don't see it in the preview (nor the code). But X logo looks great - thanks a lot :)

If you like, we can merge this, but then the issue still remains open for Mastodon - so maybe you could try to include it as well. It'll be just a few lines of code more.

uniqueg
uniqueg requested changes Feb 23, 2024
View reviewed changes
Copy link
Member

@uniqueg uniqueg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add Mastodon as well, if possible.

@valens200
Copy link
Contributor Author

Please add Mastodon as well, if possible.

Please add Mastodon as well, if possible.
Thank you so much @uniqueg, the Mastodon was added. Now you can merge the pull request.

@uniqueg uniqueg changed the title feat(contributors): add Twitter icons feat(contributors): add Twitter & Mastodon icons Feb 23, 2024
@valens200 valens200 merged commit 6b03757 into dev Feb 23, 2024
2 checks passed
@valens200 valens200 deleted the valens branch February 23, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uniqueg uniqueg uniqueg approved these changes

@anuragxxd anuragxxd anuragxxd left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@valens200 @uniqueg @anuragxxd